Skip to content

Commit 1ca9a95

Browse files
cpojerfacebook-github-bot
authored andcommitted
Move WebView Android files to FB internal
Summary: This moves the Java files to FB internal and updates all the buck files Reviewed By: TheSavior Differential Revision: D14622521 fbshipit-source-id: a8d293e9f9e08868cca3ed2986a08d0db16dec15
1 parent 556aa93 commit 1ca9a95

File tree

10 files changed

+1
-1001
lines changed

10 files changed

+1
-1001
lines changed

ReactAndroid/src/main/java/com/facebook/react/shell/BUCK

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ rn_android_library(
6262
react_native_target("java/com/facebook/react/views/toolbar:toolbar"),
6363
react_native_target("java/com/facebook/react/views/view:view"),
6464
react_native_target("java/com/facebook/react/views/viewpager:viewpager"),
65-
react_native_target("java/com/facebook/react/views/webview:webview"),
6665
react_native_target("java/com/facebook/react/module/annotations:annotations"),
6766
react_native_target("res:shell"),
6867
],

ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

-2
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
import com.facebook.react.views.toolbar.ReactToolbarManager;
6363
import com.facebook.react.views.view.ReactViewManager;
6464
import com.facebook.react.views.viewpager.ReactViewPagerManager;
65-
import com.facebook.react.views.webview.ReactWebViewManager;
6665
import java.util.ArrayList;
6766
import java.util.Arrays;
6867
import java.util.List;
@@ -337,7 +336,6 @@ public List<ViewManager> createViewManagers(ReactApplicationContext reactContext
337336
viewManagers.add(new ReactSliderManager());
338337
viewManagers.add(new ReactSwitchManager());
339338
viewManagers.add(new ReactToolbarManager());
340-
viewManagers.add(new ReactWebViewManager());
341339
viewManagers.add(new SwipeRefreshLayoutManager());
342340

343341
// Native equivalents

ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java

+1-13
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ protected void onAfterUpdateTransaction(@Nonnull T view) {
129129
/**
130130
* Subclasses may use this method to receive events/commands directly from JS through the
131131
* {@link UIManager}. Good example of such a command would be {@code scrollTo} request with
132-
* coordinates for a {@link ScrollView} or {@code goBack} request for a {@link WebView} instance.
132+
* coordinates for a {@link ScrollView} instance.
133133
*
134134
* @param root View instance that should receive the command
135135
* @param commandId code of the command
@@ -144,18 +144,6 @@ public void receiveCommand(@Nonnull T root, int commandId, @Nullable ReadableArr
144144
* map between names of the commands and IDs that are then used in {@link #receiveCommand} method
145145
* whenever the command is dispatched for this particular {@link ViewManager}.
146146
*
147-
* As an example we may consider {@link ReactWebViewManager} that expose the following commands:
148-
* goBack, goForward, reload. In this case the map returned from {@link #getCommandsMap} from
149-
* {@link ReactWebViewManager} will look as follows:
150-
* {
151-
* "goBack": 1,
152-
* "goForward": 2,
153-
* "reload": 3,
154-
* }
155-
*
156-
* Now assuming that "reload" command is dispatched through {@link UIManagerModule} we trigger
157-
* {@link ReactWebViewManager#receiveCommand} passing "3" as {@code commandId} argument.
158-
*
159147
* @return map of string to int mapping of the expected commands
160148
*/
161149
public @Nullable Map<String, Integer> getCommandsMap() {

ReactAndroid/src/main/java/com/facebook/react/views/webview/BUCK

-18
This file was deleted.

0 commit comments

Comments
 (0)