Skip to content

Commit 1a42bd6

Browse files
jimmy623facebook-github-bot
authored andcommitted
Add UIAccessibilityTraitUpdatesFrequently to progressBar role
Summary: Changelog: Add UIAccessibilityTraitUpdatesFrequently when the AccessibilityRole is set to progressBar. This trait tells the accessibility system where content may change with every percentage point, but without annoying the user with constant announcements. Reviewed By: ikenwoo Differential Revision: D30510587 fbshipit-source-id: e75690a2a56ce42476dc999383cf58c0811fcbdf
1 parent ee3e71f commit 1a42bd6

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

React/Views/RCTViewManager.m

+3-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ @implementation RCTConvert (UIAccessibilityTraits)
5151
@"menu" : @(UIAccessibilityTraitNone),
5252
@"menubar" : @(UIAccessibilityTraitNone),
5353
@"menuitem" : @(UIAccessibilityTraitNone),
54-
@"progressbar" : @(UIAccessibilityTraitNone),
54+
@"progressbar" : @(UIAccessibilityTraitUpdatesFrequently),
5555
@"radio" : @(UIAccessibilityTraitNone),
5656
@"radiogroup" : @(UIAccessibilityTraitNone),
5757
@"scrollbar" : @(UIAccessibilityTraitNone),
@@ -172,7 +172,8 @@ - (RCTShadowView *)shadowView
172172
const UIAccessibilityTraits AccessibilityRolesMask = UIAccessibilityTraitNone | UIAccessibilityTraitButton |
173173
UIAccessibilityTraitLink | UIAccessibilityTraitSearchField | UIAccessibilityTraitImage |
174174
UIAccessibilityTraitKeyboardKey | UIAccessibilityTraitStaticText | UIAccessibilityTraitAdjustable |
175-
UIAccessibilityTraitHeader | UIAccessibilityTraitSummaryElement | SwitchAccessibilityTrait;
175+
UIAccessibilityTraitHeader | UIAccessibilityTraitSummaryElement | UIAccessibilityTraitTabBar |
176+
UIAccessibilityTraitUpdatesFrequently | SwitchAccessibilityTrait;
176177
view.reactAccessibilityElement.accessibilityTraits =
177178
view.reactAccessibilityElement.accessibilityTraits & ~AccessibilityRolesMask;
178179
UIAccessibilityTraits newTraits = json ? [RCTConvert UIAccessibilityTraits:json] : defaultView.accessibilityTraits;

ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h

+4
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,10 @@ inline void fromString(const std::string &string, AccessibilityTraits &result) {
9898
result = AccessibilityTraits::TabBar;
9999
return;
100100
}
101+
if (string == "progressbar") {
102+
result = AccessibilityTraits::UpdatesFrequently;
103+
return;
104+
}
101105
result = AccessibilityTraits::None;
102106
}
103107

0 commit comments

Comments
 (0)