Skip to content

Commit 1907bd3

Browse files
danilobuergerfacebook-github-bot
authored andcommitted
Remove Gemfile.lock from template (#33469)
Summary: For the same reason we don't keep a yarn.lock or Podfile.lock, we shouldn't be keeping a Gemfile.lock in the template. The user will generate this on his own pulling in the current dependencies with the constraints in Gemfile. No need to lock to a specific version. cc barbieri (author of #32303) cc ravirajn22 (for raising the issue) ## Changelog [iOS] [Fixed] - Remove Gemfile.lock from template Pull Request resolved: #33469 Test Plan: no test plan Reviewed By: javache Differential Revision: D35074105 Pulled By: cortinico fbshipit-source-id: 47d1b92329f1d55d4a0adbacbc7e5e45f9d957e0
1 parent 4d91f40 commit 1907bd3

File tree

2 files changed

+2
-104
lines changed

2 files changed

+2
-104
lines changed

scripts/update-ruby.sh

+2-4
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,15 @@ echo "$VERSION" > template/_ruby-version
5353
sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" Gemfile
5454
sed_i -e "s/^\(ruby '\)[^']*\('.*\)$/\1$VERSION\2/" template/Gemfile
5555

56-
rm -f Gemfile.lock template/Gemfile.lock
56+
rm -f Gemfile.lock
5757

5858
export BUNDLE_APP_CONFIG="$ROOT/.bundle"
5959
cp "$BUNDLE_APP_CONFIG/"* template/_bundle # sync!
6060

6161
bundle lock
62-
(cd template && bundle lock)
6362

6463
git add \
6564
.ruby-version \
6665
Gemfile \
6766
template/_ruby-version \
68-
template/Gemfile \
69-
template/Gemfile.lock
67+
template/Gemfile

template/Gemfile.lock

-100
This file was deleted.

0 commit comments

Comments
 (0)