Skip to content

Commit 1542f83

Browse files
philIipfacebook-github-bot
authored andcommitted
fix RCTImageLoaderTests
Summary: we couldn't run the RNTesterUnitTests before because these tests didn't respect the nullability specification. after this diff, we can run the tests. as for the tests.... well 2 are still failing, i'm taking a look at them. Changelog: [iOS][Fixed] - fixed RCTImageLoaderTests Reviewed By: sammy-SC Differential Revision: D32635689 fbshipit-source-id: d68ae6a3e7f1370d7d76d68c7a6d9812928e6c12
1 parent 00ac034 commit 1542f83

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ - (void)testImageLoading
7070
XCTAssertEqual(progress, 1);
7171
XCTAssertEqual(total, 1);
7272
}
73-
partialLoadBlock:nil
73+
partialLoadBlock:^(UIImage *loadedImage) {}
7474
completionBlock:^(NSError *loadError, id loadedImage) {
7575
XCTAssertEqualObjects(loadedImage, image);
7676
XCTAssertNil(loadError);
@@ -129,7 +129,7 @@ - (void)testImageLoaderUsesImageURLLoaderWithHighestPriority
129129
XCTAssertEqual(progress, 1);
130130
XCTAssertEqual(total, 1);
131131
}
132-
partialLoadBlock:nil
132+
partialLoadBlock:^(UIImage *loadedImage) {}
133133
completionBlock:^(NSError *loadError, id loadedImage) {
134134
XCTAssertEqualObjects(loadedImage, image);
135135
XCTAssertNil(loadError);

0 commit comments

Comments
 (0)