Skip to content

Commit 145fd04

Browse files
ryancatfacebook-github-bot
authored andcommitted
Fix crash on empty snapToOffsets prop to ScrollView
Summary: When the `snapToOffsets` prop is empty array, the scroll view would crash unexpectly. This diff fixed that by treating empty array prop as null value for `snapToOffsets`. Changelog: [Android][Fixed] - Fix crash on empty snapToOffsets array Reviewed By: makovkastar Differential Revision: D34802022 fbshipit-source-id: af330512e444081b0cb02b65288ec5cd2bd14205
1 parent 2f813f8 commit 145fd04

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void setSnapToAlignment(ReactHorizontalScrollView view, String alignment)
109109
@ReactProp(name = "snapToOffsets")
110110
public void setSnapToOffsets(
111111
ReactHorizontalScrollView view, @Nullable ReadableArray snapToOffsets) {
112-
if (snapToOffsets == null) {
112+
if (snapToOffsets == null || snapToOffsets.size() == 0) {
113113
view.setSnapOffsets(null);
114114
return;
115115
}

ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public void setSnapToInterval(ReactScrollView view, float snapToInterval) {
102102

103103
@ReactProp(name = "snapToOffsets")
104104
public void setSnapToOffsets(ReactScrollView view, @Nullable ReadableArray snapToOffsets) {
105-
if (snapToOffsets == null) {
105+
if (snapToOffsets == null || snapToOffsets.size() == 0) {
106106
view.setSnapOffsets(null);
107107
return;
108108
}

0 commit comments

Comments
 (0)