Skip to content

Commit 0bcc686

Browse files
PaitoAndersonfacebook-github-bot
authored andcommitted
Fix iOS Image.getSizeWithHeaders (#29338)
Summary: Fixes #28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: #29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
1 parent 4b935ae commit 0bcc686

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Libraries/Image/RCTImageLoader.mm

+5-1
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,11 @@ - (void)cancelRequest:(id)requestToken
11631163
resolve:(RCTPromiseResolveBlock)resolve
11641164
reject:(RCTPromiseRejectBlock)reject)
11651165
{
1166-
NSURLRequest *request = [RCTConvert NSURLRequest:uri];
1166+
NSURL *URL = [RCTConvert NSURL:uri];
1167+
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:URL];
1168+
[headers enumerateKeysAndObjectsUsingBlock:^(NSString *key, id value, BOOL *stop) {
1169+
[request addValue:[RCTConvert NSString:value] forHTTPHeaderField:key];
1170+
}];
11671171
[self getImageSizeForURLRequest:request
11681172
block:^(NSError *error, CGSize size) {
11691173
if (error) {

0 commit comments

Comments
 (0)