Skip to content

Commit 009d80b

Browse files
arhelmusfacebook-github-bot
authored andcommitted
Dropped using namespace from TurboModuleUtils.h
Summary: using namespace in header file is a bad practice due to many reasons as well as discouraged by `-Wheader-hygiene` compiler flag which is default for many apps https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers Changelog: [General][Fixed] - Fixed compilation warning due to `using namespace` being used as part of header Reviewed By: nlutsenko Differential Revision: D34788523 fbshipit-source-id: 2a50fbf2ac3371ff5670c600c7f5ad9055060ad2
1 parent 2a5265d commit 009d80b

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/ReactCommon/OnLoad.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
#include "TurboModuleManager.h"
1313

1414
void jniEnableCppLogging(
15-
jni::alias_ref<jclass> cls,
16-
jni::alias_ref<facebook::react::JNativeModulePerfLogger::javaobject>
17-
perfLogger) {
15+
facebook::jni::alias_ref<jclass> cls,
16+
facebook::jni::alias_ref<
17+
facebook::react::JNativeModulePerfLogger::javaobject> perfLogger) {
1818
facebook::react::TurboModulePerfLogger::enableLogging(
1919
perfLogger->cthis()->get());
2020
}

ReactCommon/react/nativemodule/core/ReactCommon/TurboModuleUtils.h

-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
#include <ReactCommon/CallInvoker.h>
1616
#include <ReactCommon/LongLivedObject.h>
1717

18-
using namespace facebook;
19-
2018
namespace facebook {
2119
namespace react {
2220

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.mm

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#import <ReactCommon/TurboModulePerfLogger.h>
2828
#import <ReactCommon/TurboModuleUtils.h>
2929

30+
using namespace facebook;
3031
using namespace facebook::react;
3132

3233
static int32_t getUniqueId()

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModuleManager.mm

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#import <ReactCommon/TurboModuleBinding.h>
2929
#import <ReactCommon/TurboModulePerfLogger.h>
3030

31+
using namespace facebook;
3132
using namespace facebook::react;
3233

3334
/**

0 commit comments

Comments
 (0)