fby4: sd: Add retry for checking presence of DIMMs #2232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Summary: # Description - It's for JIRA-1502 - Add a retry mechanism (10 laps) for SD BIC checking the presence of DIMMs. - Run clang-format. # Motivation - BIC only checks the presence of DIMMs one time. - If it failed at that time, BIC will not monitor the DIMMs until BIC reboot. Test Plan: - Build code: Pass - AC cycle stress: Pass
yikaitsaiww
force-pushed
the
yikai/dimm_presence_retry
branch
from
cda1025 to
52f9851
Compare
|
@wescylin has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in 89ee564. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Test Plan: