Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork adding support for ES modules #315

Open
drjeffjackson opened this issue Apr 4, 2024 · 7 comments
Open

Fork adding support for ES modules #315

drjeffjackson opened this issue Apr 4, 2024 · 7 comments

Comments

@drjeffjackson
Copy link

I have made a fork that adds an --esm switch that generates an ES modules version of the app. Are you accepting pull requests, and if so, would you be interested in this one?

@UlisesGascon
Copy link
Member

Hi @drjeffjackson! Feel free to do a PR with the changes 👍

@drjeffjackson
Copy link
Author

drjeffjackson commented Apr 4, 2024

Thanks, @UlisesGascon! PR #316 submitted.

@joeyguerra
Copy link

PR #314 adds Python 2 to the runner, which should fix some of the failing tests in #316.

@IgorArnaut
Copy link

IgorArnaut commented Jan 22, 2025

How do I make sure I'm installing your fork and not the original? Both have the same package name.

EDIT: The README of your fork is literally copy-paste from this repo's README.

@drjeffjackson
Copy link
Author

How do I make sure I'm installing your fork and not the original? Both have the same package name.

My fork is in pull request #316. It is still waiting to be approved for merging, but you're welcome to clone it from https://github.com/drjeffjackson/expressjs-generator/tree/esm.

EDIT: The README of your fork is literally copy-paste from this repo's README.

The README of the esm branch of my clone of the repo has a slightly modified README that adds documentation of a new --es6 switch.

@IgorArnaut
Copy link

How do I make sure I'm installing your fork and not the original? Both have the same package name.

My fork is in pull request #316. It is still waiting to be approved for merging, but you're welcome to clone it from https://github.com/drjeffjackson/expressjs-generator/tree/esm.

EDIT: The README of your fork is literally copy-paste from this repo's README.

The README of the esm branch of my clone of the repo has a slightly modified README that adds documentation of a new --es6 switch.

Thank you for clarifying, but I don't believe that it will be merged. There was a similar six year old PR that was not merged. #200

@drjeffjackson
Copy link
Author

Thank you for clarifying, but I don't believe that it will be merged. There was a similar six year old PR that was not merged. #200

I've just made a change requested by @ljharb (removed node='module' from package.json). Perhaps that will make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants