[VH] Schema version mismatch results in failed instead of open (inconsistent with iOS)

[mlenkeit]

Describe the bug

If the SchemaVersion field of a rule is greater or equal then the ver field of a DCC (e.g. SchemaVersion=1.3.0 and ver=1.0.0), the rule results in fail:

dgc-certlogic-android/engine/src/main/java/dgca/verifier/app/engine/DefaultCertLogicEngine.kt

Lines 82 to 91 in 5a53b77

	hcertVersion.isGreaterOrEqualThan(schemaVersion) ->
	when (jsonLogicValidator.isDataValid(
	rule.logic,
	dataJsonNode
	)) {
	true -> Result.PASSED
	false -> Result.FAIL
	else -> Result.OPEN
	}
	else -> Result.FAIL

Expected behaviour

The result should result in open, just like it is implemented on iOS:

https://github.com/eu-digital-green-certificates/dgc-certlogic-ios/blob/8b7f86a2aed4f2c60dd2c7c4f28eb129d9fe379d/Sources/CertLogic/CertLogic.swift#L52-L54

Steps to reproduce the issue

Apply a rule with SchemaVersion set to 1.3.0 (e.g. Netherlands) against a DCC with ver set to 1.0.0 (e.g. most German DCCs)

Technical details

n/a

Possible Fix

map to open instead of fail

Additional context

[oleksandrsarapulovgl]

PR: #41

[oleksandrsarapulovgl]

Another PR: https://github.com/corona-warn-app/dgc-certlogic-android/tree/improve-error-handling

[oleksandrsarapulovgl]

Hi @mlenkeit ! Thank you for finding the issue. May I close it now?

[MYMY33]

Ciao e possibile avere un qr code grazie