common: ensure that EIPs enforce required EIPs are active

packages/common/src/eips/2930.json

@@ -15,6 +15,7 @@
         "d": "Gas cost per storage key in an Access List transaction"
       }
     },
+    "requiredEIPs": [2718, 2929],
     "vm": {},
     "pow": {}
   }

packages/common/src/index.ts

@@ -236,6 +236,14 @@ export default class Common {
           `${eip} cannot be activated on hardfork ${this.hardfork()}, minimumHardfork: ${minHF}`
         )
       }
+      if (EIPs[eip].requiredEIPs) {
+        // eslint-disable-next-line prettier/prettier
+        (<number[]>EIPs[eip].requiredEIPs).forEach((elem: number) => {
+          if (!eips.includes(elem)) {
+            throw new Error(`${eip} requires EIP ${elem}, but is not included in the EIP list`)
+          }
+        })
+      }
     }
     this._eips = eips
   }

packages/common/tests/eips.ts

@@ -32,4 +32,25 @@ tape('[Common]: Initialization / Chain params', function (t: tape.Test) {
 
     st.end()
   })
+
+  t.test(
+    'Should throw when trying to initialize with an EIP which requires certain EIPs, but which are not included on the EIP list',
+    function (st: tape.Test) {
+      const eips = [2930]
+      const msg =
+        'should throw when initializing with an EIP, which does not have required EIPs on the EIP list'
+      const f = () => {
+        new Common({ chain: 'mainnet', eips, hardfork: 'berlin' })
+      }
+      st.throws(f, msg)
+      st.end()
+    }
+  )
+
+  t.test('Should not throw when initializing with a valid EIP list', function (st: tape.Test) {
+    const eips = [2718, 2929, 2930]
+    new Common({ chain: 'mainnet', eips, hardfork: 'berlin' })
+    st.pass('initialized correctly')
+    st.end()
+  })
 })