Add EIP: EOF - TXCREATE and InitcodeTransaction type #9299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
Co-authored-by: pdobacz <[email protected]>
SamWilsn
reviewed
Feb 3, 2025
EIPS/eip-xxxx.md
Outdated
| @@ -0,0 +1,209 @@ | |||
| --- | |||
There was a problem hiding this comment.
Suggested change
| --- | |
| --- | |
| eip: 7873 |
Don't forget to rename the file as well!
Hello |
gumb0
changed the title
octavio12345300
approved these changes
Feb 4, 2025
shemnon
reviewed
Feb 4, 2025
EIPS/eip-7873.md
Outdated
Comment on lines
63
to
71
| ```python | ||
| initcode_cost = 0 | ||
| for initcode in tx.initcodes: | ||
| for byte in initcode: | ||
| if byte == 0: | ||
| initcode_cost += TX_DATA_COST_PER_ZERO | ||
| else: | ||
| initcode_cost += TX_DATA_COST_PER_NON_ZERO | ||
| ``` |
There was a problem hiding this comment.
If initcodes costs the same as call data then we need to have this code reflect [EIP-7623)[https://eips.ethereum.org/EIPS/eip-7623], which has a different formulation but includes the "floor" cost.
There was a problem hiding this comment.
True, there's TODO above about this.
There was a problem hiding this comment.
I rewrote initcodes codes cost section to be based on EIP-7623.
octavio12345300
approved these changes
Feb 6, 2025
|
✅ All reviewers have approved. |
eth-bot
added
e-consensus
g11tech
reviewed
Feb 12, 2025
|
|
||
| ## Security Considerations | ||
|
|
||
| Needs discussion. |
There was a problem hiding this comment.
insert a <-- TODO --> html tag for bot to remind you before moving status after draft
g11tech
approved these changes
Feb 13, 2025
eth-bot
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also corresponding EOF mega-spec change ipsilon/eof#177