Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7607: Add EIP-7823 (Set upper bounds for MODEXP) to proposeed-for-inclusion in Fusaka #9251

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Update EIP-7607: Add EIP-7823 (Set upper bounds for MODEXP) to proposeed-for-inclusion in Fusaka #9251

merged 1 commit into from
Jan 23, 2025

Conversation

axic
Copy link
Member

@axic axic commented Jan 17, 2025

See the motivation for more details:

  1. Removes unused unbounded cases. Such cases are known to have caused numerous consensus bugs in the past.
  2. Makes it easier for ZK systems to implement this precompile -- and many already have a similar limitation in place (like Polygon zkEVM).
  3. Makes it easier to implement the precompile using EVMMAX.

@axic axic requested a review from eth-bot as a code owner January 17, 2025 19:57
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-meta labels Jan 17, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 17, 2025 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jan 17, 2025
@axic axic mentioned this pull request Jan 17, 2025
Closed
@eth-bot eth-bot enabled auto-merge (squash) January 23, 2025 23:05
eth-bot
eth-bot approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit a2ed823 into ethereum:master Jan 23, 2025
10 checks passed
@axic axic deleted the patch-2 branch January 24, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbeiko timbeiko timbeiko approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @eth-bot @timbeiko