-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry auth failures and require leader in ElectionImpl. #1337
Retry auth failures and require leader in ElectionImpl. #1337
Conversation
Perhaps we should do the same for the lock API; my team is not currently using that so I did not think about it at first. You can let me know if you'd like me to do the same changes for lock, I think it would make sense. |
@jcferretti whatever you can do to help the project would be more than welcome since my time, as you have noticed, is very very limited |
Understood, will do. I will add to this same PR and change the title to reflect the scope. I'll have something to you by tomorrow. |
Done, PTAL at your convenience. |
Tests pass locally for me:
The failure on the github PR checks is on
Not sure how the code in this PR could have broken that one. |
@jcferretti can you squash the commits ? (and sign off the commit if you can) |
752496c
to
62a9f05
Compare
Signed-off-by: Cristian Ferretti <[email protected]>
62a9f05
to
f0bd80f
Compare
Force-pushed to fix DCO (commit sign-off). |
Fixes #1336
Also adds require leader in LockImpl; LockImpl was already using execute, so auth retries were happening there.