Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about referral links #4431

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add note about referral links #4431

merged 2 commits into from
Nov 12, 2024

Conversation

jesserockz
Copy link
Member

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit eaae65e
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6732cf5ad0f9020008eb3b51
😎 Deploy Preview https://deploy-preview-4431--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 30cf88f
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/6732d0fe7680630008e8e2c5
😎 Deploy Preview https://deploy-preview-4431--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Walkthrough

The pull request introduces enhancements to the guides/contributing.rst file for the ESPHome project. Key changes include the addition of a new section titled "Contributing Links," which specifies that referral links are prohibited unless they directly benefit the project. Additional notes have been incorporated to clarify expectations regarding tests, image optimization, and formatting standards for contributions. These modifications aim to improve the clarity and comprehensiveness of the contribution guidelines.

Changes

File Change Summary
guides/contributing.rst - Added a new section "Contributing Links" prohibiting referral links unless they benefit the project.
- Added notes on passing tests, image optimization, and formatting standards for contributions.

Possibly related PRs

Suggested reviewers

  • kbx81

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f4226cb and 30cf88f.

📒 Files selected for processing (1)
  • guides/contributing.rst (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
guides/contributing.rst (1)

Pattern **: - Do not generate or add any sequence diagrams

🔇 Additional comments (4)
guides/contributing.rst (4)

197-198: LGTM: New section header follows RST syntax guidelines

The addition of the "Contributing Links" section with proper reference label is well-structured.


208-212: LGTM: Clear policy statement about referral links

The note about referral links is well-formatted and provides clear guidance about the project's policy.


505-505: LGTM: Helpful image optimization command

The added imagemagick command provides a useful tool for contributors to optimize their images.


1036-1036: LGTM: Clarification about external components

The added clarification about YAML configuration for external components enhances the documentation.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jesserockz 👍

../Frenck

@frenck frenck merged commit 52e1824 into current Nov 12, 2024
3 checks passed
@frenck frenck deleted the jesserockz-2024-511 branch November 12, 2024 07:22
@jesserockz jesserockz mentioned this pull request Nov 13, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2024
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants