Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Support for WoW:classic #78

Open
guppy42 opened this issue Aug 29, 2019 · 2 comments
Open

[Feature request] Support for WoW:classic #78

guppy42 opened this issue Aug 29, 2019 · 2 comments

Comments

@guppy42
Copy link

guppy42 commented Aug 29, 2019

Any chance this could support classic?

Looking at:
https://github.com/ephraim/lcurse/blob/master/modules/waitdlg.py#L197

It seems that simply checking the 5th td's div would get your the version number ( it's wrapped in div.mr-2 )

ofcourse classic is in it's own folder classic not retail

@timwienk
Copy link
Contributor

Since #80 is merged, I think this is solved and can be closed.

@jukx
Copy link

jukx commented Dec 19, 2019

There's still some bugs.

For one, I couldn't get it to recognize my wow installation, as I didn't have retail installed and https://github.com/ephraim/lcurse/blob/master/modules/preferences.py#L53 checks for that.

When I fixed that then the updater only updated like 5 out of 50 addons... Haven't investigated further as to why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants