Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curse URL has changed #58

Open
jwhipp opened this issue Nov 9, 2017 · 6 comments
Open

Curse URL has changed #58

jwhipp opened this issue Nov 9, 2017 · 6 comments

Comments

@jwhipp
Copy link

jwhipp commented Nov 9, 2017

I noted lcurse stopped being able to find a few add-ons. Going to the curse site, it appears you're now redirected to https://www.curseforge.com/wow/addons/.

Looks like lcurse needs to update the source URL now. Gotta love Curse and their random changes.

@makerbeleg
Copy link

I confirm, does not work at all for me

@alar77
Copy link
Contributor

alar77 commented Nov 13, 2017

Worst thing is that the version number is gone from the first page.... I am trying to fix it in my fork and will submit a PR if I succeed

@alarofrunetotem
Copy link

alarofrunetotem commented Nov 13, 2017

pull-request is up. You can get it from my repository (same user of previous comment, I plainehate how github is not smart in managing 2 accounts)

@ilu33
Copy link

ilu33 commented Nov 24, 2017

Ephraims version is not working anymore so I tried yours, Alar. This is what I get:

python3 /opt/lcurse-alar/lcurse
Folders Preferences/wowfolder /home/.../.wine/drive_c/Program Files (x86)/World of Warcraft
Traceback (most recent call last):
  File "/opt/lcurse-alar/lcurse", line 44, in <module>
    from modules import application
  File "/opt/lcurse-alar/modules/application.py", line 19, in <module>
    from modules import waitdlg
  File "/opt/lcurse-alar/modules/waitdlg.py", line 15, in <module>
    from cryptography.hazmat.primitives.hashes import MD5
ImportError: No module named 'cryptography'

After some searching I decided to install the package python3-cryptography and now things seem to work. You should note that under dependencies.
Thank you for keeping this up-to-date!

@alar77
Copy link
Contributor

alar77 commented Nov 24, 2017

I am glad it works, I didnt add (at least, not willingly) any dependency, had you already installed ephraims version before or you started straight on with mine?

@ilu33
Copy link

ilu33 commented Nov 24, 2017

I had an older version of Ephraims before. In the version I used there was no cryptography or hash function in waitdlg.py. I think he introduced this sometime ago and made another change recently, see https://github.com/ephraim/lcurse/commit/ef70ea78882fd19d47cd60afdeb98d4d12382ade - but without eliminating the dependency, contrary to what the title says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants