Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update addon if filename has a space #51

Open
Nuadh opened this issue Mar 2, 2017 · 2 comments
Open

Cannot update addon if filename has a space #51

Nuadh opened this issue Mar 2, 2017 · 2 comments

Comments

@Nuadh
Copy link

Nuadh commented Mar 2, 2017

As title say, if the download redirect goes to a filename with a space, the client fails to update the addon with the error (in console): Could not open $filename , retrying...5 times, ending with HTTP Error 400: Bad Request.

I fixed the issue by adding a line at line 171 in waitdlg.py:
downloadLink = re.sub(r" ", "%20", downloadLink)
right below:
downloadLink = soup.select(".download-link")[0].get('data-href')

@ephraim
Copy link
Owner

ephraim commented May 1, 2017

Do you have an example addon? .... So I can test my changes?

@Nuadh
Copy link
Author

Nuadh commented May 1, 2017

Back when it was an issue, it was "http://mods.curse.com/addons/wow/quest_completist", if it's fixed now on their side, I don't know.

*Edit: it seems to be fixed on their side now, filename is "QuestCompletist_v107.zip" now, no spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants