Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entgql: add support for query fields selection #463

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Conversation

a8m
Copy link
Member

@a8m a8m commented Mar 19, 2023

Note that if the schema was extended, an unrecognized field was queried, entgql skips the fields selection because we cannot determine if a non-selected field is used in custom resolvers.

Wait with the review until I add tests to this PR.

Note that in case the schema was extended an unrecognized field was queried,
entgql skips the fields selection because we cannot determine if a non-selected
field is used in custom resolvers
@a8m a8m force-pushed the fieldselection branch from fc4a4b6 to 61a5db9 Compare March 19, 2023 15:53
Copy link
Collaborator

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@a8m a8m merged commit e6390f9 into master Mar 19, 2023
@a8m a8m deleted the fieldselection branch March 19, 2023 16:09
giautm added a commit that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants