Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entgql: fix outputWriter non-order dependencies #409

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Conversation

giautm
Copy link
Collaborator

@giautm giautm commented Nov 20, 2022

Signed-off-by: Giau. Tran Minh [email protected]

@giautm giautm requested a review from a8m November 20, 2022 18:19
@@ -236,6 +233,12 @@ func (e *Extension) genSchemaHook() gen.Hook {
if err != nil {
return err
}
if e.outputWriter == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already check this above, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@giautm giautm merged commit ac820c5 into master Nov 21, 2022
@giautm giautm deleted the giautm/output-writer branch November 21, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants