Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entgql: initial work for nested pagination in templates #277

Merged
merged 1 commit into from
Apr 5, 2022
Merged

entgql: initial work for nested pagination in templates #277

merged 1 commit into from
Apr 5, 2022

Conversation

a8m
Copy link
Member

@a8m a8m commented Mar 31, 2022 •
edited
Loading

PR is ready for review. Implementation examples exist in entgql/internal/todo/todo_test.go#926.

Additional parts that should be added after this PR:

  • It's better IMO, to not rely on gqlgen to unmarshal and load the arguments and move the (un)marshling logic of <T>WhereInput types to ent.
  • Add additional tests/examples and publish a tutorial or a blog post about it?
  • The code for loading the totalCount can be improved by removing some of the duplications there.

masseelch
masseelch reviewed Mar 31, 2022
View reviewed changes
@a8m a8m force-pushed the eagerload branch 6 times, most recently from 85aefa8 to ded8ab7 Compare April 2, 2022 19:02
@a8m a8m force-pushed the eagerload branch 4 times, most recently from e81cf06 to 6b90760 Compare April 4, 2022 19:36
@a8m a8m marked this pull request as ready for review April 4, 2022 19:37
@a8m a8m force-pushed the eagerload branch 3 times, most recently from 9a0b519 to 6ff07e2 Compare April 5, 2022 06:06
giautm
giautm approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should upgrade ent/gqlgen in the separated commit to avoid changes in other packages.

@a8m a8m force-pushed the eagerload branch 2 times, most recently from 4f5ff26 to b39535a Compare April 5, 2022 09:04
@a8m a8m merged commit 945c677 into master Apr 5, 2022
@a8m a8m deleted the eagerload branch April 5, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masseelch masseelch masseelch left review comments

@giautm giautm giautm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a8m @giautm @masseelch