-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entgql: move generate WhereInput logic to single hook #275
Conversation
3a8ac9a
to
6c724c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @giautm. I added minor comments.
entgql.WithSchemaHook(func(g *gen.Graph, s *ast.Schema) error { | ||
return nil | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @crossworth, what do you think about this hook? Is it satisfied with this comment? #267 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @giautm great work!
I have made a few small (and fast) tests and it worked without problems, I think this adds a lot of possibilities.
Maybe in the future we can collect the most common usages for schema hooks and add "helper functions".
Like adding/removing a field/directive, this should make even easier to the consumers.
I can't wait to use all this new features that you guys are adding.
I can't see the lint comment. Don't know why, :-/ |
About the lint error, looks like it's about a panic: I had to add the code below to
|
Thanks, @crossworth, please feel free to contribute and fix this. I failed back to go 1.17 for now to unblock our PRs. |
This commit isn't working, because WhereInput was failed to find `CategoryConfigInput` from the config.
Co-authored-by: Ariel Mashraki <[email protected]>
a27a450
to
76e262f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
No description provided.