Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entproto: add Skip annotation #187

Merged
merged 8 commits into from
Dec 24, 2021
Merged

entproto: add Skip annotation #187

merged 8 commits into from
Dec 24, 2021

Conversation

iivankin
Copy link
Contributor

Allows us to skip the generation of the specified fields and edges.

@rotemtam
Copy link
Collaborator

Hey,
Thanks for working on this.
Great start!
Can you please add a unit test in https://github.com/ent/contrib/blob/master/entproto/internal/entprototest/adapter_test.go
That asserts that skipped fields don't appear in the proto descriptor?

Thanks 🙏

@rotemtam
Copy link
Collaborator

Also CI is red , ping me on slack if you need assistance with getting it to pass

a8m
a8m approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. minor style comments

@rotemtam rotemtam merged commit dcb3272 into ent:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iivankin @rotemtam @a8m