Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript rewrite? #251

Closed
erikian opened this issue Dec 4, 2022 · 2 comments · Fixed by #320
Closed

Typescript rewrite? #251

erikian opened this issue Dec 4, 2022 · 2 comments · Fixed by #320
Labels
enhancement released

Comments

@erikian
Copy link
Member

erikian commented Dec 4, 2022

Any plans to rewrite this library in Typescript? Would a PR be welcome?
@malept
Copy link
Member

malept commented Dec 4, 2022

I think this library needs a much more robust testsuite before it can get rewritten. This library is too essential to the ecosystem to be rewritten unless the tests back it up or the person doing the rewrite can demonstrate a deep understanding of the format and its edge cases.

This was referenced Aug 16, 2024
Closed
Merged
@continuous-auth Continuous Auth
Copy link

🎉 This issue has been resolved in version 3.2.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rewrite to typescript retaining API electron/asar
3 participants
@malept @erickzhao @erikian