Add partitioned to cookie for SignalR browser testing #57997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using `Secure` and `Same-Site=None`
dotnet-issue-labeler
bot
added
the
area-signalr
amcasey
approved these changes
Sep 20, 2024
Co-authored-by: Andrew Casey <[email protected]>
halter73
approved these changes
Sep 20, 2024
|
You got me thinking Chrome had actually started blocking third-party cookies like they've been talking about and then read the description 😄
|
Soon™️ |
|
Merging before I log off for the weekend as the Helix job is unaffected by this change |
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Add partitioned to cookie for SignalR browser testing Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using `Secure` and `Same-Site=None` * Apply suggestions from code review Co-authored-by: Andrew Casey <[email protected]> --------- Co-authored-by: Andrew Casey <[email protected]>
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Add partitioned to cookie for SignalR browser testing Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using `Secure` and `Same-Site=None` * Apply suggestions from code review Co-authored-by: Andrew Casey <[email protected]> --------- Co-authored-by: Andrew Casey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using
SecureandSame-Site=None