[release/9.0] [Identity][Templates] Ensure placeholders don't overlap with text #57789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-mvc
This was referenced Sep 11, 2024
RussKie
approved these changes
Sep 12, 2024
|
@javiercn has this been approved for servicing? |
|
@RussKie I haven't taking it through servicing just yet. You normally don't have to worry about this PRs unless they are marked |
javiercn
added
the
Servicing-consider
mkArtakMSFT
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Thanks @javiercn!
Both the screenshot with current issue and the video recording were very useful.
javiercn
added
Servicing-approved
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
… with text (#57789) Backport of #57783 to release/9.0 /cc @javiercn # [Identity][Templates] Ensure placeholders don't overlap with text Placeholder text on input textboxes overlaps with the label texts. ## Description * As part of an accessibility fix, we started displaying placeholders on input elements. * In some circumstances, these placeholders overlap with the labels on the input text boxes, making it problematic to read them. * The fix addresses this by reducing the size of the placeholders and making inputs bigger to avoid any overlap. Fixes dotnet/AspNetCore-ManualTests#3081 ## Customer Impact When the window size is small enough, customers could see overlapped text that's hard to read and is sometimes even impossible. ## Regression? - [X] Yes - [ ] No 8.0 since we introduced this behavior on 9.0 as part of accessibility fixes. ## Risk - [ ] High - [ ] Medium - [x] Low The attached videos serve as validation of the fix, in addition to that, the UI is completely customizable by customers. ## Verification - [X] Manual (required) - [ ] Automated **Old behavior**   **New behavior** https://github.com/user-attachments/assets/6eae3396-9794-402d-af65-e0bc89257a44 https://github.com/user-attachments/assets/0343b4fc-5f55-4e46-a276-67c4c97645e2 ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
… with text (#57789) Backport of #57783 to release/9.0 /cc @javiercn # [Identity][Templates] Ensure placeholders don't overlap with text Placeholder text on input textboxes overlaps with the label texts. ## Description * As part of an accessibility fix, we started displaying placeholders on input elements. * In some circumstances, these placeholders overlap with the labels on the input text boxes, making it problematic to read them. * The fix addresses this by reducing the size of the placeholders and making inputs bigger to avoid any overlap. Fixes dotnet/AspNetCore-ManualTests#3081 ## Customer Impact When the window size is small enough, customers could see overlapped text that's hard to read and is sometimes even impossible. ## Regression? - [X] Yes - [ ] No 8.0 since we introduced this behavior on 9.0 as part of accessibility fixes. ## Risk - [ ] High - [ ] Medium - [x] Low The attached videos serve as validation of the fix, in addition to that, the UI is completely customizable by customers. ## Verification - [X] Manual (required) - [ ] Automated **Old behavior**   **New behavior** https://github.com/user-attachments/assets/6eae3396-9794-402d-af65-e0bc89257a44 https://github.com/user-attachments/assets/0343b4fc-5f55-4e46-a276-67c4c97645e2 ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57783 to release/9.0
/cc @javiercn
[Identity][Templates] Ensure placeholders don't overlap with text
Placeholder text on input textboxes overlaps with the label texts.
Description
Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3081
Customer Impact
When the window size is small enough, customers could see overlapped text that's hard to read and is sometimes even impossible.
Regression?
8.0 since we introduced this behavior on 9.0 as part of accessibility fixes.
Risk
The attached videos serve as validation of the fix, in addition to that, the UI is completely customizable by customers.
Verification
Old behavior
New behavior
AccessibilityFix.mp4
Fix_MVC.mp4
Packaging changes reviewed?
When servicing release/2.1