Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams #57471

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Aug 22, 2024

The test has been rewritten, looks thread-safe, and hasn't failed in 30 days.

Fixes #30309

…amsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams

The test has been rewritten, looks thread-safe, and hasn't failed in 30 days.

Fixes dotnet#30309
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Aug 22, 2024
@amcasey amcasey changed the title Unquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Fix Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Aug 22, 2024
@amcasey
Copy link
Member Author

amcasey commented Aug 22, 2024

CI failures are known. I won't bother to re-run until people have reviewed.

@JamesNK JamesNK changed the title Fix Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Unquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Aug 22, 2024
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on the issue name 😄

@amcasey
Copy link
Member Author

amcasey commented Aug 23, 2024

nit on the issue name 😄

I fixed the others, but I think this one actually is unquarantining.

Edit: Oh, I see, I overcorrected. 😆

@amcasey amcasey enabled auto-merge (squash) August 23, 2024 00:04
@amcasey amcasey merged commit 63c492e into dotnet:main Aug 24, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 24, 2024
@danroth27 danroth27 added the task label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions task
Projects
None yet
3 participants