-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add double-dash to args if there are previous app-host-added args #7769
base: main
Are you sure you want to change the base?
Only add double-dash to args if there are previous app-host-added args #7769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
…gs-when-no-apphost-args
…dash" This reverts commit d128b27.
Correct. They should be unncessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just do the check internally to the method.
Please do some testing with this in the playground just to make sure there are no rough edges here. |
Even if there are previous app host added args, the double dash could be excluded from what is displayed to the user by not adding it to the custom annotation. |
Description
It doesn't appear that a double-dash is required to be prepended to application launch args when there are no app host arguments. @mitchdenny does this make sense?
Fixes #7751
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):