Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates moved by one day when set international and also formatting error #123

Closed
shriharip opened this issue Jul 2, 2019 · 4 comments · Fixed by #165
Closed

Dates moved by one day when set international and also formatting error #123

shriharip opened this issue Jul 2, 2019 · 4 comments · Fixed by #165
Labels
feature request good first issue Good for newcomers priority Need attention

Comments

@shriharip
Copy link

shriharip commented Jul 2, 2019

Version of flutter_calendar_carousel

1.3.18

Expected behavior

Issue 1
Week view and month view should show similar dates and days.

Issue 2,
when the locale is set, then the text formatting should also be appropriate

Actual behavior

Issue 1.
The date between the two calendars should be the same. However, as you can see in the below attachments the dates (in week view) shows "1" as Tuesday and '2' as Wednesday, whereas the full month view shows them correctly where 1 is Monday and 2 is Tuesday
When showing week view the dates are moved by one day.

Simulator Screen Shot - iPhone XS - 2019-07-02 at 12 54 14
Simulator Screen Shot - iPhone XS - 2019-07-02 at 12 54 49

Issue 2.
On Week view Monday is shown in red (weekend format), whereas in the month view it is shown properly. I can raise a separate issue for this.

flutter doctor result (run flutter doctor in terminal)

✓] Flutter (Channel dev, v1.5.8, on Mac OS X 10.13.6 17G65, locale en-DK)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.3)
[✓] VS Code (version 1.35.1)
[✓] Connected device (1 available)

Steps to reproduce the behavior

I have just done git clone of the repo and using the example app, passing the locale as string 'da'.
I have just enabled expanded arrow button to hide the other calendar which by default shows up in the example you have

last but not the least thanks for the good library it is great :)

EDIT: found that even without locale it is having the same issue with dates. On week view it is one day added for July, but in the month view, it is perfect.

@hyochan
Copy link
Owner

hyochan commented Sep 13, 2019

Thank you for the great issue. I might have to debug on the first issue as soon as possible.
Looks very promising.

@thesmalleyes
Copy link

I have this problem too, the date and the day is not match, the difference is a day

@saeedjassani
Copy link

Thanks for such a great library.

Getting this issue with the example code month view too. Any idea by when this will be fixed?

@hyochan
Copy link
Owner

hyochan commented Oct 12, 2019

@godon019 Would you prefer to help people with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers priority Need attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants