Replace object-like array with class #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new class is templatable, which should enable us to specify that the ORM Lexer is an Lexer<self::T_*>, and in the future, define an enum called TokenType in the ORM, and switch to Lexer<TokenType>.
greg0ire
commented
Nov 29, 2022
| use function in_array; | ||
|
|
||
| /** @template T of string|int */ | ||
| final class Token |
There was a problem hiding this comment.
Because I'm reusing this name, I need to rename the type alias in AbstractLexer to ArrayToken, which should break static analysis.
Dang, I thought we'd be able to leverage https://psalm.dev/docs/annotating_code/type_syntax/conditional_types/ to know what we're dealing with, but I wrongly assumed we'd be able to check feature flag :/ |
|
I would expect the |
|
Closing in favor of the more sensible #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #79 (which I still prefer)
The new class is templatable, which should enable us to specify that the ORM Lexer is an
Lexer<self::T_*>, and in the future, define an enum called TokenType in the ORM, and switch toLexer<TokenType>.I tested on the ORM, and with this solution, the PHPUnit test suite no longer breaks.
The static analysis is broken because of the impossibility to know if we have an array or an object, and because I want to reuse the
Tokenname.I've considered adding another template param to
AbstractLexerto fix this, but then it would have to be removed in 2.0, which would make implementing compatibility with 2.0 challenging from the SA point of view.