Fix DeprecationWarning from pkg_resources #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit hook installs 0.3.3, but it didn't actually work with the pre-0.2.0-style config in pyproject.toml https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md#020
craigds
force-pushed
the
fix-deprecationwarning
branch
from
5a58eb0 to
f1fcb50
Compare
Use `importlib.metadata` (python 3.8+) or `importlib_metadata` instead
craigds
force-pushed
the
fix-deprecationwarning
branch
from
f1fcb50 to
939b99d
Compare
cclauss
approved these changes
Apr 4, 2024
|
Any chance this could reach a release on PyPI soon? I can't run pysolr on Python 3.12 due to EDIT: turns out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
importlib.metadata(python 3.8+) orimportlib_metadatainstead.I get two test fails on py312, but they don't seem related - errors connecting to solr. Other environments pass
Fixes #464