fix: pallet_asset: use did origin check, instead of account #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amar Tumballi <[email protected]>
|
@smohan-dw check if these are in right track. Anything major I missed? Also I was thinking if transfers should have the authorization check at all. As long as signature check passes, it should go through IMO to keep it much faster than create/issue |
smohan-dw
previously approved these changes
Jan 11, 2024
Signed-off-by: Amar Tumballi <[email protected]>
Signed-off-by: Amar Tumballi <[email protected]>
|
This can wait till we get the corresponding changes in SDK (@cord.network/asset). Wanted to have it here as a reference. |
smohan-dw
approved these changes
Jan 13, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.