fix(NavBar): adjust styling for nav items #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://fix-navbar-styles.d1gko6en628vir.amplifyapp.com |
longmatthewh
force-pushed
the
fix/navbar-styles
branch
from
9ade374 to
abcff1d
Compare
longmatthewh
changed the title
scurker
requested changes
Mar 8, 2023
There was a problem hiding this comment.
I discussed this with @bobbyomari. General research has suggested that some people have more difficulty reading all capital letters vs not:
- https://www.a11yproject.com/posts/how-to-accessible-heading-structure/#all-caps
- https://www.w3.org/TR/low-vision-needs/#capitalization
While not officially a wcag violation, we should probably err on the side of caution and try to follow best practices as best as we can.
@bobbyomari said we will likely make updates in UX pin to match this. Everything else looks good.
longmatthewh
force-pushed
the
fix/navbar-styles
branch
from
abcff1d to
0483319
Compare
scurker
approved these changes
Mar 8, 2023
|
Preview branch generated at https://fix-navbar-styles.d1gko6en628vir.amplifyapp.com |
This was referenced Mar 21, 2023
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @bobbyomari I made the following adjustments to the NavItem css:
--font-weight-normalfor nav items unless they're active, in which case, use--font-weight-medium