Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove base TableHeader from sort styles #882

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: remove base TableHeader from sort styles #882

merged 1 commit into from
Feb 3, 2023

Conversation

anastasialanz
Copy link
Contributor

@anastasialanz anastasialanz commented Feb 3, 2023 •
edited
Loading

This PR fixes a bug that was causing the table header to use --table-header-sorting-background-color by default even when the table header wasn't sorted.

UXPin - Tables
Screenshot from UXPin Light Theme
Screen Shot 2023-02-02 at 5 46 57 PM

Screenshot from UXPin Dark Theme
Screen Shot 2023-02-02 at 5 47 34 PM

This change is fixing a breaking change in 5.0.0. Would that mean that the version bumps to 5.0.1?

Verification steps

Reproduce the bug

Screen Shot 2023-02-02 at 5 46 32 PM

Screen Shot 2023-02-02 at 5 55 27 PM

Verify the fix

Screen Shot 2023-02-02 at 5 40 42 PM

Screen Shot 2023-02-02 at 5 53 57 PM

@anastasialanz anastasialanz requested a review from a team as a code owner February 3, 2023 00:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Preview branch generated at https://fix--table-header-css.d1gko6en628vir.amplifyapp.com

@anastasialanz
fix: remove base TableHeader from sort styles
9788451 
This reverts the change that was causing the table header to use
`--table-header-sorting-background-color` by default even when the table
header wasn't sorted.
stephenmathieson
stephenmathieson approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephenmathieson
Copy link
Member

IIRC the issue I attempted to fix was the background color wasn’t being applied to the selected header on the initial render. May need to circle back after this lands to fix that issue (since we don’t have a way to test it here).

@anastasialanz
Copy link
Contributor Author

IIRC the issue I attempted to fix was the background color wasn’t being applied to the selected header on the initial render. May need to circle back after this lands to fix that issue (since we don’t have a way to test it here).

Is this something that happens in one of your apps? We could make a new issue for it.

@anastasialanz anastasialanz merged commit be2baed into develop Feb 3, 2023
@anastasialanz anastasialanz deleted the fix--table-header-css branch February 3, 2023 14:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Preview branch generated at https://fix--table-header-css.d1gko6en628vir.amplifyapp.com

@stephenmathieson
Copy link
Member

Is this something that happens in one of your apps? We could make a new issue for it.

Yes, in a few places. #883

This was referenced Mar 21, 2023
Closed
Closed
@scurker scurker mentioned this pull request Mar 30, 2023
Closed
This was referenced Apr 4, 2023
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anastasialanz @stephenmathieson @scurker