Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement new versions of modals and alerts #88

Merged
merged 8 commits into from
Oct 8, 2020
Merged

feat: implement new versions of modals and alerts #88

merged 8 commits into from
Oct 8, 2020

Conversation

scurker
Copy link
Member

@scurker scurker commented Sep 25, 2020 •
edited by schne324
Loading

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Tested for accessibility
  • Code is reviewed for security

@scurker scurker marked this pull request as ready for review September 30, 2020 16:35
@awpearlm
Copy link

awpearlm commented Oct 7, 2020

The way it's coded now with focus going all the way to the edge for the close X is fine

schne324
schne324 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- looks like our alerts/modals don't technically "remove" focusable elements from the tab order outside of the modal but that issue pre-existed this patch. I will create a ticket to address this (maybe using inert)

@scurker scurker merged commit dbc3431 into develop Oct 8, 2020
@scurker scurker deleted the modals-and-dialogs-and-alerts-oh-my branch October 8, 2020 01:06
This was referenced Nov 5, 2020
Closed
Closed
@scurker scurker mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schne324 schne324 schne324 approved these changes

@awpearlm awpearlm Awaiting requested review from awpearlm

@bobbyomari bobbyomari Awaiting requested review from bobbyomari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scurker @awpearlm @schne324