Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow users to use thin link button #849

Merged
merged 2 commits into from
Jan 12, 2023
Merged

fix: allow users to use thin link button #849

merged 2 commits into from
Jan 12, 2023

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Jan 12, 2023 •
edited
Loading

Closes: #845
image

@michael-siek michael-siek requested a review from a team as a code owner January 12, 2023 21:59
stephenmathieson
stephenmathieson previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but someone from @dequelabs/cauldron-team should take a look

@github-actions
Copy link
Contributor

Preview branch generated at https://fix-845.d1gko6en628vir.amplifyapp.com

scurker
scurker previously requested changes Jan 12, 2023
View reviewed changes
@michael-siek michael-siek requested a review from scurker January 12, 2023 22:22
@michael-siek michael-siek enabled auto-merge (squash) January 12, 2023 22:22
@scurker scurker disabled auto-merge January 12, 2023 22:23
@scurker scurker enabled auto-merge (squash) January 12, 2023 22:23
@scurker scurker merged commit 299bd7a into develop Jan 12, 2023
@scurker scurker deleted the fix/845 branch January 12, 2023 22:23
@github-actions
Copy link
Contributor

Preview branch generated at https://fix-845.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

@stephenmathieson stephenmathieson stephenmathieson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

link as a thin and primary button has incorrect padding and font weight
3 participants
@michael-siek @stephenmathieson @scurker