Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change div to span inside of ExpandCollapse #818

Merged
merged 3 commits into from
Oct 26, 2022
Merged

fix: change div to span inside of ExpandCollapse #818

merged 3 commits into from
Oct 26, 2022

Conversation

anastasialanz
Copy link
Contributor

@anastasialanz anastasialanz commented Oct 24, 2022 •
edited
Loading

Closes #224

The div inside of the ExpandCollapse button produced invalid HTML. The ExpandCollapse component is also used in the Accordion. Since the ExpandCollapse__trigger-title is a flex box element, the display property is still set to block when changed to a span and nothing changes visually.

This PR
Screen Shot 2022-10-25 at 8 12 57 AM

Production
Screen Shot 2022-10-25 at 8 14 04 AM

Validation

<!doctype html>
<html lang="en">
<title>Test</title>

<!-- PASTE OUTER HTML HERE -->

</html>

@github-actions
Copy link
Contributor

Preview branch generated at https://fix--expand-collapse-html.d1gko6en628vir.amplifyapp.com

@anastasialanz anastasialanz linked an issue Oct 24, 2022 that may be closed by this pull request
ExpandCollapsePanel produces invalid HTML #224
Closed
@anastasialanz
fix: change div to span inside of ExpandCollapse
d6269e3 
div's inside of buttons produce invalid HTML.

Fixes #224
@anastasialanz anastasialanz force-pushed the fix--expand-collapse-html branch from a62c612 to d6269e3 Compare October 25, 2022 14:59
@anastasialanz anastasialanz marked this pull request as ready for review October 25, 2022 15:12
@anastasialanz anastasialanz requested a review from a team as a code owner October 25, 2022 15:12
@anastasialanz anastasialanz merged commit ded5fda into develop Oct 26, 2022
@anastasialanz anastasialanz deleted the fix--expand-collapse-html branch October 26, 2022 14:36
@github-actions
Copy link
Contributor

Preview branch generated at https://fix--expand-collapse-html.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpandCollapsePanel produces invalid HTML
3 participants
@anastasialanz @scurker @abbeyperini-deque