Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LoaderOverlay): export LoaderOverlayProps interface #812

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix(LoaderOverlay): export LoaderOverlayProps interface #812

merged 1 commit into from
Oct 18, 2022

Conversation

dbowling
Copy link
Contributor

Add missing export so users can extend the LoaderOverlay component.

@dbowling
fix(LoadeOverlay): export LoaderOverlayProps interface
4571ec6 
Added missing export so users can extend the LoderOverlay component.
@github-actions
Copy link
Contributor

Preview branch generated at https://fix-loader-overlay-export.d1gko6en628vir.amplifyapp.com

@dbowling dbowling marked this pull request as ready for review October 18, 2022 14:42
@dbowling dbowling requested a review from a team as a code owner October 18, 2022 14:42
scurker
scurker reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a heads up, assuming that our types are exported correctly, you can also infer the interface via typescript without an implicit type:

import { Component } from '@deque/cauldron-react'
type ComponentProps = React.ComponentProps<typeof Component>

@dbowling dbowling merged commit 2930b9c into develop Oct 18, 2022
@dbowling dbowling deleted the fix-loader-overlay-export branch October 18, 2022 19:56
@github-actions
Copy link
Contributor

Preview branch generated at https://fix-loader-overlay-export.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker left review comments

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbowling @stephenmathieson @scurker