feat(styles): update tooltip styles to support dark theme #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://update-tooltip-styles.d1gko6en628vir.amplifyapp.com |
|
Looks good! |
scurker
reviewed
Jul 21, 2022
Comment on lines
126
to
128
| font-size: 16px; | ||
| color: var(--gray-90); | ||
| padding: 16px 28px; |
There was a problem hiding this comment.
Not a blocker since it's not part of your PR:
Only commenting because I noticed, but font-size and padding should really be using our cauldron vars.
There was a problem hiding this comment.
Created a ticket: #707. We may want to just fix it when we update the big tooltip to support dark theme, since I'm guessing the designs will change a bit at that time anyway
scurker
approved these changes
Jul 21, 2022
|
Preview branch generated at https://update-tooltip-styles.d1gko6en628vir.amplifyapp.com |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409