-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update checkboxes and radio states to match new iconography #68
Conversation
The color of the checkbox looks off. In uxpin it is when I set color to current state of preview deploy: NOTE: your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same fill problem with the radios too... a simple color: #333
(or whatever var
we have for that value) would do the trick
@@ -175,6 +175,7 @@ textarea.Field--has-error:hover, | |||
box-sizing: border-box; | |||
cursor: pointer; | |||
border-radius: 3px; | |||
color: #333; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#333
is a variable...should we use that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have it as a variable, but --header-text-color-dark
felt too specific. This is an area where I wish we had a palette of variable colors.
Checkboxes: https://preview.uxpin.com/d5edf1a87ff0b75bd373b4d46d9811316ff5b287#/pages/117874572
Radios: https://preview.uxpin.com/d5edf1a87ff0b75bd373b4d46d9811316ff5b287#/pages/117876319
Reviewer checks
Required fields, to be filled out by PR reviewer(s)