Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update checkboxes and radio states to match new iconography #68

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

scurker
Copy link
Member

@scurker scurker commented Aug 5, 2020

Checkboxes: https://preview.uxpin.com/d5edf1a87ff0b75bd373b4d46d9811316ff5b287#/pages/117874572
Radios: https://preview.uxpin.com/d5edf1a87ff0b75bd373b4d46d9811316ff5b287#/pages/117876319

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Tested for accessibility
  • Code is reviewed for security

@schne324
Copy link
Member

schne324 commented Aug 5, 2020

The color of the checkbox looks off. In uxpin it is #333333

when I set color to #333333 in the devtools in the preview deploy:

Screen Shot 2020-08-05 at 11 52 39 AM

current state of preview deploy:

Screen Shot 2020-08-05 at 11 52 46 AM

NOTE: your currentColor approach is definitely the best way to go, its just that we haven't set color on the overlay div so it inherits the base color which is #666666

Copy link
Member

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same fill problem with the radios too... a simple color: #333 (or whatever var we have for that value) would do the trick

@@ -175,6 +175,7 @@ textarea.Field--has-error:hover,
box-sizing: border-box;
cursor: pointer;
border-radius: 3px;
color: #333;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#333 is a variable...should we use that here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have it as a variable, but --header-text-color-dark felt too specific. This is an area where I wish we had a palette of variable colors.

@scurker scurker merged commit e2d2268 into develop Aug 6, 2020
@scurker scurker deleted the checkboxesandradiosohmy branch August 6, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants