Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds an accordion component to library #669

Merged
merged 130 commits into from
Jul 1, 2022
Merged

feat: adds an accordion component to library #669

merged 130 commits into from
Jul 1, 2022

Conversation

tbusillo
Copy link
Contributor

@tbusillo tbusillo commented Jun 9, 2022 •
edited
Loading

ref: #650

FYI, updated UX Pin for component was put in the pin for Cauldron: https://preview.uxpin.com/68df515d0023cc4b79f25d43f7663e24e363b1b9#/pages/150823418/simulate/sitemap

tbusillo and others added 30 commits May 26, 2022 17:15
@tbusillo
feat: accordion component now available for use
ec89b01
@tbusillo
box shadow now renders on hover
a31102a
@tbusillo
additional work matching styling
7e2fa8e
@tbusillo
adds initial layout for docs and skeleton
3699941
@tbusillo
adds feature to overwrite expand/collapse panel classname if passed a…
239ce3d 
… class
@tbusillo
adds styled example without dynamic functionality
6052209
@tbusillo
tries different approach for managing state
0c55341
@tbusillo
adds aria-controls to button and id to panel
c238262
@tbusillo
fixes random id being generated on every render
47e885d
@tbusillo
adds additional styling
eea3d4e
@tbusillo
adds proof of concept for controlled vs unconrtolled
dd00a61
@tbusillo
adds max width for accordion panel
7225307
@tbusillo
adds example for checkbox accordion
7fe7792
@tbusillo
resolving merge conflict
5c3f967
@tbusillo
resolves conflict and adds icon button to example
4ea7305
@tbusillo
adds prop to hide icon and use own
905251c
@tbusillo
cleans up styling and separates light and dark styles
fbda706
@tbusillo
refines styles based on feedback
ce0a8de
@tbusillo
adds initial test cases
3a0ea11
@tbusillo
adds additional test coverage
8cb0c88
@tbusillo
adds test coverage for controlled accordion
b26cfc7
@tbusillo
adds more branch coverage
f8cff22
@tbusillo
completes 100 percent test coverage
b305415
@tbusillo
adds id to trigger element and aria-labelledby to content
040c671
@tbusillo
fixes icon hover styling and adds accessibility tests
4c1f4dc
@tbusillo
cleans up exports/imports and files
d9f110c
@tbusillo
removes max width and min height and moves to demo style
36bf249
@tbusillo
cleans up css
a5560f9
@tbusillo
adds hover state for darkmode trigger text
fdf01cd
@tbusillo
changes dark theme trigger hover to accent light
f8b0613
@tbusillo tbusillo marked this pull request as ready for review June 29, 2022 18:50
scurker
scurker requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few more things.

@tbusillo tbusillo requested a review from scurker June 30, 2022 19:40
@tbusillo tbusillo merged commit 7fd7d09 into develop Jul 1, 2022
@tbusillo tbusillo deleted the feat/accordion-component branch July 1, 2022 04:53
@scurker scurker mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dequejosie dequejosie dequejosie left review comments

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbusillo @scurker @dequejosie