Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PanelTrigger): add icon override #634

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

longmatthewh
Copy link
Contributor

@longmatthewh longmatthewh commented Apr 22, 2022

Adds 2 new optional props:

  • expandedIcon
  • collapsedIcon

This enables devs to use alternatives to the chevron-right and chevron-down icons.

Closes: #633

@longmatthewh longmatthewh requested a review from a team as a code owner April 22, 2022 15:18
@github-actions
Copy link
Contributor

@longmatthewh longmatthewh self-assigned this Apr 22, 2022
@longmatthewh longmatthewh enabled auto-merge (squash) April 22, 2022 15:27
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs documentation.

I'm not opposed to this change, but is this something that is in @awpearlm or @bobbyomari's designs?

@longmatthewh
Copy link
Contributor Author

@scurker this was driven by a Monitor design where I'm using ExpandCollapsePanel for (notice the different icons)
Screenshot from 2022-04-22 11-39-58

@scurker
Copy link
Member

scurker commented Apr 22, 2022

@scurker this was driven by a Monitor design where I'm using ExpandCollapsePanel for (notice the different icons)

Thanks for the info! I just wanted to make sure this had designs behind it.

So the only thing missing is updating the docs page here. FYI I do think in the future the above pattern also will exist elsewhere so we will likely elevate it to its own pattern while the ExpandCollapsePanel provides the underlying functionality.

@longmatthewh
Copy link
Contributor Author

@scurker docs have been updated

@longmatthewh longmatthewh requested a review from scurker April 22, 2022 16:33
@longmatthewh longmatthewh merged commit 4881208 into develop Apr 22, 2022
@longmatthewh longmatthewh deleted the feat/custom-paneltrigger-icons branch April 22, 2022 20:07
@github-actions
Copy link
Contributor

@scurker scurker mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PanelTrigger]: Add ability to override icons
2 participants