-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PanelTrigger): add icon override #634
Conversation
Preview branch generated at https://feat-custom-paneltrigger-icons.d1gko6en628vir.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs documentation.
I'm not opposed to this change, but is this something that is in @awpearlm or @bobbyomari's designs?
packages/react/src/components/ExpandCollapsePanel/PanelTrigger.tsx
Outdated
Show resolved
Hide resolved
@scurker this was driven by a Monitor design where I'm using ExpandCollapsePanel for (notice the different icons) |
Thanks for the info! I just wanted to make sure this had designs behind it. So the only thing missing is updating the docs page here. FYI I do think in the future the above pattern also will exist elsewhere so we will likely elevate it to its own pattern while the |
@scurker docs have been updated |
Preview branch generated at https://feat-custom-paneltrigger-icons.d1gko6en628vir.amplifyapp.com |
Adds 2 new optional props:
expandedIcon
collapsedIcon
This enables devs to use alternatives to the
chevron-right
andchevron-down
icons.Closes: #633