feat(react): add skip link to 2 column panel #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://feat-column-skip.d1gko6en628vir.amplifyapp.com |
scurker
previously requested changes
Apr 6, 2022
| @@ -134,7 +135,7 @@ function TwoColumnPanelDemo() { | |||
|
|
|||
| <h3>Example</h3> | |||
|
|
|||
| <Code role="region" tabIndex="1">{`<TwoColumnPanel> | |||
| <Code role="region" tabIndex="1">{`<TwoColumnPanel: | |||
There was a problem hiding this comment.
Suggested change
| <Code role="region" tabIndex="1">{`<TwoColumnPanel: | |
| <Code role="region" tabIndex="1">{`<TwoColumnPanel> |
|
There was also a few missing details that I got clarified in the linked issue, we need to ensure that the skip link is only visible when the panel is not collapsed. |
scurker
previously requested changes
Apr 8, 2022
Co-authored-by: Jason <[email protected]>
scurker
approved these changes
Apr 12, 2022
|
Preview branch generated at https://feat-column-skip.d1gko6en628vir.amplifyapp.com |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#598