fix(skip-link): fix skip-link styles with new design #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scurker
previously requested changes
Apr 4, 2022
| @@ -1,19 +1,17 @@ | |||
| :root { | |||
| --skip-link-background-color: rgba(11, 14, 17, 0.9); | |||
| --skip-link-background-color: rgba(255, 255, 255, 0.95); | |||
There was a problem hiding this comment.
Did you check with @awpearlm on this? The UX isn't clear, the notes say it's 90% opacity but the actual spec shows 95%.
There was a problem hiding this comment.
I don't know if anything needs to change where, just want to validate that 95% is correct.
There was a problem hiding this comment.
I was just going off the uxpin notes.
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason <[email protected]>
… into skiplink-styles
scurker
approved these changes
Apr 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #455
The whitespace between the spans isn't needed as the
display: blockcauses a whitespace.