Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): fix color contrast issue with toast dismiss button in dark theme #600

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix(styles): fix color contrast issue with toast dismiss button in dark theme #600

merged 1 commit into from
Mar 28, 2022

Conversation

scurker
Copy link
Member

@scurker scurker commented Mar 25, 2022

closes #583

@scurker scurker requested a review from a team as a code owner March 25, 2022 21:17
@github-actions
Copy link
Contributor

Preview branch generated at https://toast-dismiss-color.d1gko6en628vir.amplifyapp.com

@scurker scurker merged commit ab60e8d into develop Mar 28, 2022
@scurker scurker deleted the toast-dismiss-color branch March 28, 2022 21:03
@github-actions
Copy link
Contributor

Preview branch generated at https://toast-dismiss-color.d1gko6en628vir.amplifyapp.com

@scurker scurker mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isner isner isner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Dark mode, <Toast /> close button's focus indicator color lacks 3:1 contrast ratio.
2 participants
@scurker @isner