Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for button-secondary to link #540

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

thuey
Copy link
Collaborator

@thuey thuey commented Feb 7, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Preview branch generated at https://secondary-button-link.d1gko6en628vir.amplifyapp.com

@thuey thuey requested a review from a team February 7, 2022 17:01
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to fix line-heights for links that appear as buttons, not blocking your PR but just noticed this.

@thuey
Copy link
Collaborator Author

thuey commented Feb 7, 2022

Looks like we need to fix line-heights for links that appear as buttons, not blocking your PR but just noticed this.

Yeah, there seem to be a few things that are off. I created a separate ticket: #541

@thuey thuey merged commit 30f2d0e into develop Feb 7, 2022
@thuey thuey deleted the secondary-button-link branch February 7, 2022 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Preview branch generated at https://secondary-button-link.d1gko6en628vir.amplifyapp.com

@scurker scurker mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants