fix(styles): fix unnecessary border from lists inside of cards #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://fix-card-li.d1gko6en628vir.amplifyapp.com |
dequejosie
reviewed
Jan 28, 2022
| @@ -75,10 +75,6 @@ | |||
| box-sizing: border-box; | |||
| } | |||
|
|
|||
| .Card__content ul li { | |||
There was a problem hiding this comment.
Do we have any list inside .Card__content that actually requires the border? I don't recall any, but maybe we should check with @awpearlm or @bobbyomari
There was a problem hiding this comment.
I asked @schne324 about this and he doesn't know, but regardless this is way too generic of a selector. If we intended to have some sort of list components inside of a card we need something more specific.
schne324
approved these changes
Jan 28, 2022
|
Preview branch generated at https://fix-card-li.d1gko6en628vir.amplifyapp.com |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a pagination inside of a card pattern, but the list items there are showing a border on the bottom: