feat(radiogroup): add labelDescription prop to radio items #514
Conversation
|
Preview branch generated at https://feat-radio-item-description.d1gko6en628vir.amplifyapp.com |
packages/styles/forms.css
Outdated
| font-size: var(--text-size-small); | ||
| font-weight: var(--font-weight-normal); | ||
| line-height: 1; | ||
| margin: 0 0 0 30px; |
There was a problem hiding this comment.
Nitpick: This should probably match the computed width of the icon, unfortunately we don't have icon size anywhere as a variable so that is something that we should probably refactor in cauldron somewhere else. At a minimum, we could use calc:
margin-right: calc(24px + 2px + var(--space-half));24px- icon size2px- borders (left and right)var(--space-half)matching the natural spacing between the input and the text
I don't recall why we put an invisible border around the input though 🤔
There was a problem hiding this comment.
fair enough, i was looking for an icon size var and didn't see one. I will update to use the proposed value.
There was a problem hiding this comment.
Might want to pass this by @awpearlm as well if he's not already aware
@awpearlm - Had a CSS change for the desc text that @bobbyomari will be working on. Once he has a design, he will link it to the original issue #513 and I will make the update. Aaron also was interested in adding this prop to the checkbox element as well. I will create a new issue for that in GH.
There was a problem hiding this comment.
Reviewed the changes with @awpearlm, he approves.
|
Might want to pass this by @awpearlm as well if he's not already aware |
|
Preview branch generated at https://feat-radio-item-description.d1gko6en628vir.amplifyapp.com |
closes: #513