feat: Make Table support sorting #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://sortable-table.d1gko6en628vir.amplifyapp.com |
thuey
reviewed
Jan 17, 2022
scurker
previously requested changes
Jan 18, 2022
There was a problem hiding this comment.
Not necessarily a blocker, but the documentation seems a bit lacking for this component now:
We should try to document the various states of the table (sorted, not-sorted) to showcase different examples of usage. Since we are requiring author implemented code to maintain sorting the documentation doesn't provide a minimal example of how to implement this.
thuey
reviewed
Jan 19, 2022
thuey
reviewed
Jan 19, 2022
|
Preview branch generated at https://sortable-table.d1gko6en628vir.amplifyapp.com |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #489