fix: fix loader #504
Merged
fix: fix loader #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuey
commented
Jan 11, 2022
Comment on lines
+12
to
+35
| const LoaderOverlay = React.forwardRef<HTMLDivElement, LoaderOverlayProps>( | ||
| ({ className, variant, label, ...other }: LoaderOverlayProps, ref) => ( | ||
| <div | ||
| className={classNames( | ||
| 'Loader__overlay', | ||
| className, | ||
| variant === 'large' | ||
| ? 'Loader__overlay--large' | ||
| : variant === 'small' | ||
| ? 'Loader__overlay--small' | ||
| : '' | ||
| )} | ||
| ref={ref} | ||
| {...other} | ||
| > | ||
| <div className="Loader__overlay__loader"> | ||
| <Loader variant={variant} /> | ||
| <AxeLoader /> | ||
| </div> | ||
| {label ? <span className="Loader__overlay__label">{label}</span> : null} | ||
| {other.children} | ||
| </div> | ||
| {label ? <span className="Loader__overlay__label">{label}</span> : null} | ||
| {other.children} | ||
| </div> | ||
| )); | ||
| ) | ||
| ); |
There was a problem hiding this comment.
All that changed here was React.HTMLAttributes<HTMLDivElement> -> LoaderOverlayProps
|
Preview branch generated at https://loader-prop-types.d1gko6en628vir.amplifyapp.com |
scurker
approved these changes
Jan 11, 2022
|
Preview branch generated at https://loader-prop-types.d1gko6en628vir.amplifyapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a couple of regressions with the loader:
labelandvariantprops to be set for the loader overlay. (Since they are not included in the propTypes, they can't be set)50px auto)